Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings should allow changing sensitivity of LCD auto-on #134

Closed
gfwilliams opened this issue Mar 20, 2020 · 3 comments · Fixed by #225
Closed

Settings should allow changing sensitivity of LCD auto-on #134

gfwilliams opened this issue Mar 20, 2020 · 3 comments · Fixed by #225

Comments

@gfwilliams
Copy link
Member

@gfwilliams gfwilliams commented Mar 20, 2020

This is trivial to do, and I think would be helpful for a lot of people

@gfwilliams
Copy link
Member Author

@gfwilliams gfwilliams commented Mar 30, 2020

@detached
Copy link
Contributor

@detached detached commented Apr 3, 2020

I can imagine two different ways for implementing the sensitivity settings:

  1. exposing the relevant options as they are in the menu
  2. hiding the options behind a "Auto-On Sensitivity: low, middle, high"

Do you have a preference?

@gfwilliams
Copy link
Member Author

@gfwilliams gfwilliams commented Apr 3, 2020

From a user point of view I feel like low,middle,high is sensible, but then I also see that being a minefield of bug reports saying 'low is too high', etc. I think in a lot of cases it might be something that needs just a 10-20% tweak to work better.

I think maybe as setOptions says accelerations are used they are in internal units, where 8192 = 1g, we could make twistThreshold measured in g, and adjustable by 0.01g? It then makes it pretty easy to tweak from the default of 0.1, and hopefully not too scary :)

Also if a lot of people find that one setting is better, it would be easy to translate that into values that could be fed back into Espruino's defaults :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants