Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert apps to use require("widget_utils").hide()/show() rather than duplicating code #2196

Open
7 of 19 tasks
gfwilliams opened this issue Oct 26, 2022 · 3 comments
Open
7 of 19 tasks

Comments

@gfwilliams
Copy link
Member

gfwilliams commented Oct 26, 2022

Currently every app that wants to hide widgets does so with its own code. I just added a library and it'd be nice to change apps to use this.

Apps that look like they need changes right now are:

  • apps/lcars/lcars.app.js
  • apps/advcasio/app.js
  • apps/neonx/neonx.app.js
  • apps/pebbled/pebbled.app.js
  • apps/notanalog/notanalog.app.js
  • apps/aiclock/aiclock.app.js
  • apps/macwatch2/app.js
  • apps/limelight/limelight.app.js
  • apps/cassioWatch/app.js
  • apps/daisy/app.js
  • apps/pebble/pebble.app.js
  • apps/thering/app.js
  • apps/rebble/rebble.app.js
  • apps/imageclock/app.js
  • apps/widviz/widget.js
  • apps/bwclk/app.js
  • apps/circlesclock/app.js (still includes fallback code)
  • apps/90sclk/app.js
  • apps/widviztime/widget.js ?
@Darin755
Copy link
Contributor

Darin755 commented Oct 28, 2022

Did you mean convert?

@myxor
Copy link
Contributor

myxor commented Oct 31, 2022

Circlesclock is done with #2202

@gfwilliams gfwilliams changed the title Covert apps to use require("widget_utils").hide()/show() rather than duplicating code Convert apps to use require("widget_utils").hide()/show() rather than duplicating code Oct 31, 2022
@gfwilliams
Copy link
Member Author

gfwilliams commented Nov 23, 2022

Just to add - for anyone else looking at this, widget_utils now contains slideOn which allows the widgets to be slid onto the screen with a downwards swipe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants