Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPS Info App: Added number of satellites in view and fixed crash with GPS time #1167

Merged
merged 4 commits into from Jan 4, 2022
Merged

Conversation

HilmarSt
Copy link
Contributor

@HilmarSt HilmarSt commented Dec 22, 2021

  1. (bugfix) Workaround for a crash in toUTCString() if fix.time has the value "undefined", see #1155
  2. (improvement) The 4-dot progress indicator is replaced by the number of satellites in view.
    Tested on Bangle.js 2 with firmware 2v11

1. (bugfix) Workaround for a crash in toUTCString() if fix.time has the value "undefined", see #1155
2. (improvement) The 4-dot progress indicator is replaced by the number of satellites in view.
Tested on Bangle.js 2 with firmware 2v11
Sum up number of GPS and Beidou satellites in view.
@HilmarSt HilmarSt changed the title Update gps-info.js Update gps-info.js with number of satellites in view and fix crash with GPS time Dec 24, 2021
@HilmarSt HilmarSt changed the title Update gps-info.js with number of satellites in view and fix crash with GPS time GPS Info App: Add number of satellites in view and fix crash with GPS time Dec 26, 2021
apps/gpsinfo/gps-info.js Outdated Show resolved Hide resolved
apps/gpsinfo/gps-info.js Outdated Show resolved Hide resolved
HilmarSt and others added 2 commits Jan 3, 2022
…d as numbers)

Co-authored-by: BartS23 <10829389+BartS23@users.noreply.github.com>
...otherwise one of them is always zero.
Thanks, BartS23
@HilmarSt HilmarSt changed the title GPS Info App: Add number of satellites in view and fix crash with GPS time GPS Info App: Added number of satellites in view and fixed crash with GPS time Jan 3, 2022
@gfwilliams
Copy link
Member

@gfwilliams gfwilliams commented Jan 4, 2022

Thanks! In future please could you update the version in apps.json and the Changelog? I'll do this now though

@gfwilliams gfwilliams merged commit 83fcb59 into espruino:master Jan 4, 2022
1 check passed
gfwilliams added a commit that referenced this issue Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants