Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrono Widget 0.03 #330

Closed
wants to merge 5 commits into from
Closed

Conversation

Purple-Tentacle
Copy link
Contributor

@Purple-Tentacle Purple-Tentacle commented Apr 20, 2020

Display minutes:seconds when less than 1 hour is left.

@gfwilliams
Copy link
Member

@gfwilliams gfwilliams commented Apr 21, 2020

I guess this isn't ready to merge yet as it's using graph?

Please can you let me know next time if that's the case? Saves me merging accidentally :)

@Purple-Tentacle
Copy link
Contributor Author

@Purple-Tentacle Purple-Tentacle commented Apr 21, 2020

No, Active Pedometer uses graph, but there is no PR for this yet.
This does not, can be merged.

@gfwilliams
Copy link
Member

@gfwilliams gfwilliams commented Apr 21, 2020

Ok - I think the issue is you did a PR from your GitHub master branch.

When you do a PR it keeps updating it based on your branch - so it looks like you committed the active pedometer and that's updated this PR as well.

Closing for now - maybe you could create a branch with just the chrono widget on and PR from that, or just reopen this PR when you're happy with the active pedometer as well

@gfwilliams gfwilliams closed this Apr 21, 2020
@Purple-Tentacle
Copy link
Contributor Author

@Purple-Tentacle Purple-Tentacle commented Apr 21, 2020

Ah, did not realize that Active Pedometer was in here, too. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants