Skip to content

Conversation

@flaparoo
Copy link
Contributor

Currently, Gadgetbridge (Android) does not use the timeout value specified in a HTTP request. This is not according to the current documentation, and also not expected behaviour.

This PR fixes this - on the Bangle.js side. I've also created a PR in the Gadgetbridge repo. Both changes can be rolled-out independently.

@bobrippling
Copy link
Collaborator

Sounds good - tagging @gfwilliams with this being a central app

@gfwilliams
Copy link
Member

Just for reference, this is the PR: https://codeberg.org/Freeyourgadget/Gadgetbridge/pulls/4769

Looks good in theory, but I wonder if we want to wait 500ms more on the Bangle.js side than on the Gadgetbridge side? Because if you specify a timeout, ideally you want Gadgetbridge to timeout first, then send the error message, and then have Bangle.js parse that and report the error back?

But once that's done I don't see a problem with merging this ahead of the Gadgetbridge merge, you'll just need to increase the version number and add to the changelog too.

@flaparoo
Copy link
Contributor Author

Adding an extra 500ms on the watch side can't hurt - that's done.

And I've also included the missing updates to the Changelog and version.

@gfwilliams gfwilliams merged commit b63c819 into espruino:master Apr 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants