Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement for drawString - add a font size multiplier #978

Closed
MaBecker opened this issue Nov 23, 2016 · 5 comments
Closed

enhancement for drawString - add a font size multiplier #978

MaBecker opened this issue Nov 23, 2016 · 5 comments

Comments

@MaBecker
Copy link
Contributor

@MaBecker MaBecker commented Nov 23, 2016

Normally I use the vectorfont to draw large strings on oleds.

Using oled-i2c-bus on beaglebone brings a nice feature that allows a font size multiplier as parameter for writeString

This is how it is done Oled.prototype._drawChar - not sure how complex this will be - but like to try.

Benefit: use one fixed font in multiple size like 1:4x6, 2:8x12, 3:12x18 ......

Thought this could be a smart enhancement to have.

@gfwilliams What do you think ?

@gfwilliams

This comment has been minimized.

Copy link
Member

@gfwilliams gfwilliams commented Nov 23, 2016

Have you used Graphics.setFontVector? That gives you an actual vector font that can be resized however you want, with no pixellation. I guess it's quite possible that you're using ESP8266 and the font has been removed to save some space in flash though?

I'd try using that first and see how it goes?

@MaBecker

This comment has been minimized.

Copy link
Contributor Author

@MaBecker MaBecker commented Nov 23, 2016

Ups - have not stated that clear - Yes on Espruino I use the setFontVector - sure what else ;-)

Just a thought ..... I will do some testing and come back with results or close this issue.

@gfwilliams

This comment has been minimized.

Copy link
Member

@gfwilliams gfwilliams commented Nov 23, 2016

The actual draw code is here: https://github.com/espruino/Espruino/blob/master/libs/graphics/jswrap_graphics.c#L625

There are 3 different paths though:

  • built-in 4x6 font
  • vector font
  • custom font

The easiest option would be to add a way to set custom fonts with a scale factor - I'm not sure how much use that would be.

Maybe the most useful enhancement would be to add a scaling option to drawImage. That way you could draw whatever you wanted onto a small 'Graphics' instance and resize it?

@gfwilliams

This comment has been minimized.

Copy link
Member

@gfwilliams gfwilliams commented Mar 17, 2017

Is it fine to close this now? With the 4MB build you'll be able to include vector fonts, so will be able to resize properly

@MaBecker

This comment has been minimized.

Copy link
Contributor Author

@MaBecker MaBecker commented Mar 17, 2017

Yes I close

@MaBecker MaBecker closed this Mar 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.