Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature characteristic security #1657

Merged
merged 2 commits into from Apr 29, 2019

Conversation

@vkolotov
Copy link
Contributor

vkolotov commented Apr 27, 2019

This PR is to add support for configuring security attributes for characteristics. NRF5X devices only as I don't have any ESP device handy (although it is possible to add support for ESP as well).

I've tested this with a BT sniffer, works ok. Once you marked a characteristic rear/write with a security attribute, a secure links gets established automatically when you are trying to read/write for android (I assume for ios as well) and Bluez with generic USB adapters. Bluegiga serial adapter does not establish secure link automatically, a separate pairing procedure has to be run before reading/writing protected characteristics.

@gfwilliams

This comment has been minimized.

Copy link
Member

gfwilliams commented Apr 29, 2019

Looks great - thanks!

@gfwilliams gfwilliams merged commit e18e0b6 into espruino:master Apr 29, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.