-
Notifications
You must be signed in to change notification settings - Fork 21
Add 1 favorite locally when you favorite an app #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added session tracking for favorited apps and removed unused function.
|
The editor I'm using seems to have formatted the document differently than before, leading to a bit of a nightmare for maintainers... Hopefully I can get that fixed 🤞 |
|
Thanks! This looks good (apart from the maybe global variable favsThisSession?), but I really don't want all the random whitespace changes that are in there now! If you could fix that I'd be happy to pull it in. I guess it might be easier for you to stop the editor messing it up, then just start from scratch and copy in the few lines of changes you made? |
|
Thanks! I think that's what I'll end up doing anyway - it's a bit of a mess right now. |
|
It's fixed now, and works well! |
|
Looks great - thanks! Just merging |
When you favorite an app, the text inside the icon adds one favorite immediately, that is local and will not get pushed to the database. What this PR does is gives the illusion that the website is updating the favorites immediately, adding another layer of feedback that the user has favorited an app. This has been tested, and works with no problems.
Example: When I favorited an app before, the color fill of the heart icon would change, but not the number, since the database is not updating with every favorite. eg. (30 --> 30)
Now, if I favorite the app, the text goes from 30 --> 31, which instantly provides feedback that you indeed favorited the app, and the number has changed.
Hopefully this will help the website feel more snappy and efficient with favorite handling.