Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Output Coordinate Window does not support dark theme #371

Closed
dfoll opened this issue May 29, 2017 · 5 comments

Comments

@dfoll
Copy link
Collaborator

commented May 29, 2017

Tasks to be done June 6th 2018

  • Verify CMS issues addressed in CC and MT

Background

The Coordinate Conversion add-in needs to support the dark theme when opening the properties.
Steps to replicate:

  1. Open the Coordinate Conversion add-in
  2. Click the Add Coordinate button in the output section

Expectations:
The blue hover color will match the style set by ArcGIS Pro
The Properties window for adding a new coordinate will follow the Dark Theme style

Current state:

image

Definition of Done:
The dark theme window for properties will look like similar to this:
image

This might be useful. We addressed this issue for another add-in in this pull request:
Esri/distance-direction-addin-dotnet#493

@dfoll

This comment has been minimized.

Copy link
Collaborator Author

commented May 29, 2017

issues #369 and #370 were entered as Version-Next, I feel that we should fix those before release. This issue I think can be pushed to Version-After Next, given our current timeline.

@nfeuerstein nfeuerstein added 0 - Backlog and removed 0 - Backlog labels Jun 9, 2017

@nfeuerstein nfeuerstein modified the milestones: Version - Next, Version - After Next Jun 21, 2017

@dfoll dfoll changed the title Dark Theme Visibility Issues Dark Theme UI ssues Sep 7, 2017

@NatalieCampos NatalieCampos changed the title Dark Theme UI ssues Dark Theme UI issues Sep 7, 2017

@lfunkhouser lfunkhouser added A-bug and removed B - Bug labels Oct 6, 2017

@lfunkhouser lfunkhouser removed this from the Version - Next milestone Dec 15, 2017

@topowright

This comment has been minimized.

Copy link
Collaborator

commented Mar 1, 2018

Being that this is a duplicate issue of #464 I am changing this issue to just focus on the window for new output coordinate. How this work is done is up to the best approach from the developer. The end state is that we must support Dark Theme with this add-in

@topowright

This comment has been minimized.

Copy link
Collaborator

commented Mar 1, 2018

@dfoll @ACueva @lfunkhouser wanted to make sure everyone sees this change.

topowright added a commit that referenced this issue Apr 11, 2018
Merge pull request #487 from CTLocalGovTeam/dev
Delivery for Coordinate Conversion Addin DotNet - Sprint 2/3

All these issues have been addressed: 
- #371 
- #406 
- #464 
- #466
@topowright

This comment has been minimized.

Copy link
Collaborator

commented Apr 11, 2018

This has been addressed and verified.

@topowright topowright self-assigned this Apr 11, 2018

@lfunkhouser lfunkhouser added this to CT - Fixed in CT Project May 16, 2018

@topowright topowright removed the G-Doc (CMS) label Jun 6, 2018

@lfunkhouser lfunkhouser moved this from CT - Fixed to To Verify in CT Project Jun 6, 2018

@topowright topowright added E-verified and removed G-QC (Doc) labels Jun 6, 2018

@ACueva ACueva removed the V - Pro 2.1 label Jun 7, 2018

@lfunkhouser lfunkhouser moved this from To Verify to Closed in CT Project Nov 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
9 participants
You can’t perform that action at this time.