Upgrade metacat more intelligently #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchendrix
requested changes
Jan 24, 2020
Member
vchendrix
left a comment
vchendrix
left a comment
There was a problem hiding this comment.
The overal structure of the changes is OK but it is not quite there. Review my comments and then set a time to discuss this with me.
helbashandy
force-pushed
the
issue_134_update_upgrade
branch
from
08d808c to
6def483
Compare
vchendrix
reviewed
Jan 31, 2020
vchendrix
reviewed
Jan 31, 2020
vchendrix
reviewed
Jan 31, 2020
vchendrix
reviewed
Jan 31, 2020
vchendrix
requested changes
Jan 31, 2020
Member
There was a problem hiding this comment.
I have added some comments to the docker-entrypoint.sh changes. I would like you to think about and address the following issues.
Graceful Shutdown
Basically I would like to see a graceful tomcat shutdown. Since our application may take longer to shutdown when there is more data, we want to give the application to honor executing requests before shutting down. You don't want to kill processes unless the shutdown is taking too long.
Timeout logic and startup
What do you think the best logic is for timeout? Do you..
- exit tomcat immediatly?
- try to startup anyway?
helbashandy
force-pushed
the
issue_134_update_upgrade
branch
from
6def483 to
c4617f0
Compare
vchendrix
reviewed
Feb 4, 2020
vchendrix
reviewed
Feb 4, 2020
Issue ess-dive/ess-dive-project#134: - Check upgrade status from metacat node capabilities - Make sure port 8080 is avaialble before starting tomcat again
Closes ess-dive/ess-dive-project#134 The upgrade requires a restart and we can't confidently shutdown tomcat before a restart. The best course of action is to exit the container after an upgrade which forces the container manager to start up a new container with the upgaded application. Logic for upgrade + Perform upgrade + Determine it completes successfully + shutdown tomcat + wait for application ports to be release + exit container
vchendrix
force-pushed
the
issue_134_update_upgrade
branch
from
f450beb to
abdf3f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade metacat more intelligently by waiting for metacat node capabilities status change.
Description
Description
Closes ess-dive/ess-dive-project#134
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checked the DB loading after the upgrade.
Test Configuration