Refactor docker-entrypoint.sh to wait for postgres db to be available #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helbashandy
approved these changes
Feb 20, 2020
Contributor
helbashandy
left a comment
helbashandy
left a comment
There was a problem hiding this comment.
Looks good.
I tried starting while the db container is removed but since it's in the docker-compose as a depends_on: db it started it anyway and metacat waited for the db which is great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for postgres db to start
Description
Added while loop to wait for db:5432 to be available.
Closes #16
Type of change
How Has This Been Tested?
Made sure that you can bring an entire stack up successfully and that the metacat container waits for the postgres db to be available.
Test Configuration