Tomcat9 Upgrade for Metacat 2.12.3 #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchendrix
reviewed
Sep 25, 2020
Member
vchendrix
left a comment
vchendrix
left a comment
There was a problem hiding this comment.
The commits need to be sqashed.
Closes ess-dive/ess-dive-project#153 Upgrades tomcat7 to tomcat9 and includes the required configuration changes needed. The AJP connector had changes made to it since tomcat7 which include allowedRequestAttributesPattern, default address is the loopback address and other changes described here: https://tomcat.apache.org/migration-9.html The changes were made accordingly so that metacat and metacatui can connect with each other as shown in the server.xml.patch file. Use tomcat with jdk8 Metacat has compatability problems with jdk11. It has been suggested by the NCEAS group to downgrade and use Java 8. Add server.xml with configuration changes The configuration changes include some additional parameters to get the AJP connector working in Tomcat 9 since some changes were made. Add patch file for server
mamelara
force-pushed
the
issue_153_upgrade_metacat_tomcat9
branch
from
9c7e716 to
1851d21
Compare
Contributor
Author
|
done! |
vchendrix
approved these changes
Sep 25, 2020
Member
vchendrix
left a comment
vchendrix
left a comment
There was a problem hiding this comment.
Ran selenium tests, toolset tests and package services tests. I finished successfully. Looks great.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tomcat9 Upgrade for Metacat 2.12.3
Description
As per our discussion with NCEAS, it has been suggested that our version of tomcat be upgraded to either 8 or 9 since those include log rotation capabilities. We can leverage these capabilities to mitigate the size of
catalina.outwhich has been collecting all the stdout and stderr from the metacat application. This PR upgrades the docker image of metacat to use the base tomcat:9-jdk8 and includes configuration changes toconf/server.xmlsince changes were made to the AJP connector which metacat uses.Implements ess-dive/ess-dive-project#153
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Testing was done by building the image in
essdive-appstackand running./build.sh metacat 2.12.3to build the image.Then the changes were deployed using the
ess-dive-catalogprovision/docker-compose.ymlfile included in that repository.Once the services are up, go to
localhostand check to see that a503error does not appear. A503error would indicate that metacatui cannot get a connection to metacat.After the services are up and metacatui and metacat are connected, run the selenium tests in
ess-dive-catalog.Test Configuration