Docker deployment for Separate Solr Service #24
Conversation
helbashandy
left a comment
helbashandy
left a comment
There was a problem hiding this comment.
Looking great, I had a comment for a potential improvement on the Solr versioning.
build.sh
Outdated
| unzip "$DIR/metacat-index.war" "WEB-INF/classes/solr-home/conf/*" -d "$DIR/solr" | ||
|
|
||
| # create the docker tag | ||
| DOCKER_TAG="${VERSION}-8.4.1-p$(cd $DIR; git rev-list HEAD --count)" |
There was a problem hiding this comment.
I wonder if this could be parsed from here instead of hard coding the Solr version.
There was a problem hiding this comment.
Assuming that the same file exists in the .war file.
There was a problem hiding this comment.
I think the version of solr is in the xml file solrconfig.xml. We could probably parse it out. Not sure if we want to do that right now though. We probably want to be very thoughtful about upgrading to a new version of solr. This would be a good discussion topic for down the road. Feel free to add an issue ticket labeled discussion.
build.sh
Outdated
| fi | ||
|
|
||
| echo "docker build ${DOCKER_BUILD_OPTIONS} -f $DIR/solr/Dockerfile -t ${IMAGE_NAME} $BUILD_ARGS $DIR/" | ||
| docker pull solr:8.4.1 |
solr/Dockerfile
Outdated
| @@ -0,0 +1,5 @@ | |||
| FROM solr:8.4.1 | |||
There was a problem hiding this comment.
I think for now let's keep it this way. See comment above.
vchendrix
force-pushed
the
issue-project-99-solr-service
branch
2 times, most recently
from
d2b2fcd to
d9adda4
Compare
vchendrix
force-pushed
the
issue-project-99-solr-service
branch
2 times, most recently
from
8457d61 to
d75ac25
Compare
Co-author <vchendrix> No longer supports embedded solr in Metacat<2.13.0 Adds ESS-DIVE custom skins to image + These were ported from ess-dive-catalog. This + saves the extra step of deployments + Metacat waits for solr to startup Supports Issue ess-dive/ess-dive-project#99
vchendrix
force-pushed
the
issue-project-99-solr-service
branch
from
d75ac25 to
3336e05
Compare
This will address security vulnerabilities in 8.4 Closes #25
This paramterizes SOLR_VERSION and make sure it is reflected in the docker image name
No longer supports embedded solr in Metacat<2.13.0
Adds ESS-DIVE custom skins to image
Metacat waits for solr to startup
NOTE: version that builds for Metacat 2.12.3 has been tagged (Metacat-2.12.3)
Supports Issue ess-dive/ess-dive-project#99