Skip to content

Fix how it fail to protect signs and rails and blocks below #130

Closed
wants to merge 3 commits into from

3 participants

@Licshee
Licshee commented Aug 27, 2012

Updated isProtected method so it now checks if the sign attached or the rail above is protected.

  • It now calls getType on the right block.

Removed storage code for blocks below rails or attached by signs, since we don't need it anymore.
Removed code used to unprotect nearby blocks when a block is being destroyed.

  • Said code used to unprotect anything include signs and rails, we don't need the code anymore since we are now checking on the signs and rails themselves.
Licshee added some commits Aug 28, 2012
@Licshee Licshee fix bugs where it may fail to protect blocks
Updated isProtected method so it now checks if the sign attached or the rail above is protected.
Removed storage code for blocks below rails or attached by signs, since we don't need them anymore.
Removed how it used to unprotect nearby blocks when a block is being destroyed.
- the removed code used to unprotect anything include signs and rails, and we don't the code anymore since we are now checking the signs and rails themselves.
e4c7778
@Licshee Licshee Update EssentialsProtect/src/com/earth2me/essentials/protect/Essentia…
…lsProtectBlockListener.java

now calls getType on the right block
8e67ed1
@Licshee Licshee Update EssentialsProtect/src/com/earth2me/essentials/protect/Essentia…
…lsProtectBlockListener.java

checks signs on all four directions
94389f1
@Licshee
Licshee commented Sep 2, 2012

Oh, please!
So I can use it to protect rails on my server after next release of essentials.

@khobbits
Essentials member
khobbits commented Sep 2, 2012

Personally I've wanted to destroy this code completely for the longest time. I don't think this has a place in Essentials.
I asked ementalo to review this a few days ago, he said something needing to make sure it respected the disable toggles in the config, and then heard nothing else.

@ementalo
Essentials member
ementalo commented Oct 3, 2012

Closing as this is being removed

@ementalo ementalo closed this Oct 3, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.