Skip to content

Conversation

@JamieSinn
Copy link
Contributor

http://www.ecocitycraft.com/forum/threads/suggestion-mail.86067/
Not entirely mandatory to be added, and could be tweaked with a config option.
Here is the original message, from the above link.

"Minecraft Name: AgentHare

Suggestion: To have the command come back with Mail Sent to _________________: message you sent to them

Reason: Is very useful for getting solid evidence of you /mail ing a user to get out of your town, or other things. Could be useful for mayors or to make sure you said everything you wanted to.

Link To This Plugin: could be added?"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why this was changed. Perhaps you made a derp? ;)

@khobbits
Copy link
Member

Ok, I'm going to close this, but first I'm going to list why its wrong:

  • Committing code which wont compile
  • Multiple commits for a two line code change
  • Adding a completely new message string instead of editing the existing one.
  • Trying to use a variable that doesn't exist in the current context
  • Not updating all messages files
  • Not passing the players name to the 'sendMessage' method
  • Using the wrong substitute variable token ({1} vs {0})

I would normally let you off on the error that carlgo mentioned, but that is also wrong too.

@khobbits khobbits closed this Feb 17, 2014
@JamieSinn
Copy link
Contributor Author

I did this without really looking over my code, in wordpad, at 4am. :P

I'll resubmit later when I have some time to make a real version.

@JamieSinn JamieSinn deleted the patch-2 branch February 18, 2014 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants