diff --git a/docs/getting-started.md b/docs/getting-started.md index 0bb631f8..1b339fca 100644 --- a/docs/getting-started.md +++ b/docs/getting-started.md @@ -45,10 +45,10 @@ target: role: arn:aws:iam::123456789012:role/roleName ``` !!! note - Make sure that target role has proper trust permissions that allow to assume it cross-account +Make sure that target role has proper trust permissions that allow to assume it cross-account !!! note - In order te be able to pull images from outside accounts, you will have to apply proper access policy +In order te be able to pull images from outside accounts, you will have to apply proper access policy #### Access policy diff --git a/docs/metrics.md b/docs/metrics.md index 7b7f7ab3..d272f877 100644 --- a/docs/metrics.md +++ b/docs/metrics.md @@ -15,5 +15,6 @@ k8s_image_swapper_main_errors | Number of errors k8s_image_swapper_cache_hits | Number of registry cache hits k8s_image_swapper_cache_misses | Number of registry cache misses k8s_image_swapper_cache_filtered | Number of registry cache filtered out -k8s_image_swapper_cache_images_copied | Number of images copied +k8s_image_swapper_cache_image_copy_duration_seconds | Image copy duration in seconds +k8s_image_swapper_cache_repos_create_requests | Number of repositories create attempts k8s_image_swapper_cache_repos_created | Number of repositories created diff --git a/pkg/webhook/image_swapper.go b/pkg/webhook/image_swapper.go index 13cef069..0816055a 100644 --- a/pkg/webhook/image_swapper.go +++ b/pkg/webhook/image_swapper.go @@ -246,7 +246,6 @@ func (p *ImageSwapper) Mutate(ctx context.Context, ar *kwhmodel.AdmissionReview, case types.ImageSwapPolicyAlways: log.Ctx(lctx).Debug().Str("image", targetImage).Msg("set new container image") containers[i].Image = targetImage - metrics.IncrementCacheHits(ar.Namespace, reference.Domain(srcRef.DockerReference()), repoName) case types.ImageSwapPolicyExists: if p.registryClient.ImageExists(lctx, targetImage) { log.Ctx(lctx).Debug().Str("image", targetImage).Msg("set new container image")