From 6919f430a72df45418cfdfa051a8097ba6d3ec20 Mon Sep 17 00:00:00 2001 From: Henrik Sperre Johansen Date: Mon, 18 May 2020 16:39:25 +0200 Subject: [PATCH] Reverse incorrect conversion order in these methods - document with test. --- src/Multilingual-Tests/ByteTextConverterTest.class.st | 10 ++++++++++ src/Multilingual-TextConversion/Character.extension.st | 4 ++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/src/Multilingual-Tests/ByteTextConverterTest.class.st b/src/Multilingual-Tests/ByteTextConverterTest.class.st index 873706b5a02..c57cb0a7dea 100644 --- a/src/Multilingual-Tests/ByteTextConverterTest.class.st +++ b/src/Multilingual-Tests/ByteTextConverterTest.class.st @@ -32,6 +32,16 @@ ByteTextConverterTest >> testLatin2ToUnicodeConversion [ self assert: (unicodeString at: 4) charCode equals: (utfCodePoints at: 4) ] +{ #category : #testing } +ByteTextConverterTest >> testMacRomanToUnicodeShorthand [ + | macRomanCharacter unicodeCharacter | + macRomanCharacter := Character value: 16r80. + unicodeCharacter := $Ä. + + self assert: macRomanCharacter macRomanToUnicode equals: unicodeCharacter. + self assert: macRomanCharacter equals: unicodeCharacter unicodeToMacRoman. +] + { #category : #testing } ByteTextConverterTest >> testUnicodeToLatin2Conversion [ | latin2Bytes internalString encodingStream encodedBytes | diff --git a/src/Multilingual-TextConversion/Character.extension.st b/src/Multilingual-TextConversion/Character.extension.st index ba9d3e4caea..7df8ab1e23c 100644 --- a/src/Multilingual-TextConversion/Character.extension.st +++ b/src/Multilingual-TextConversion/Character.extension.st @@ -4,12 +4,12 @@ Extension { #name : #Character } Character >> macRomanToUnicode [ "Convert the receiver from MacRoman Unicode." - ^MacRomanTextConverter new unicodeToByte: self + ^MacRomanTextConverter new byteToUnicode: self ] { #category : #'*Multilingual-TextConversion' } Character >> unicodeToMacRoman [ "Convert the receiver from Unicode to MacRoman encoding." - ^MacRomanTextConverter new byteToUnicode: self + ^MacRomanTextConverter new unicodeToByte: self ]