From cecd6d6a64da0d79679f658fd007830ea3fda2f7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mart=C3=ADn=20Dias?= Date: Mon, 14 Oct 2019 09:11:04 -0300 Subject: [PATCH] Fix #4817. Do not log MC save anymore. --- src/Epicea-Tests/EpEventIntegrationTest.class.st | 15 --------------- src/Epicea/EpMonitor.class.st | 11 ----------- src/Epicea/MCVersionSaved.extension.st | 7 ------- 3 files changed, 33 deletions(-) delete mode 100644 src/Epicea/MCVersionSaved.extension.st diff --git a/src/Epicea-Tests/EpEventIntegrationTest.class.st b/src/Epicea-Tests/EpEventIntegrationTest.class.st index 5409de014de..17d5355d010 100644 --- a/src/Epicea-Tests/EpEventIntegrationTest.class.st +++ b/src/Epicea-Tests/EpEventIntegrationTest.class.st @@ -31,18 +31,3 @@ EpEventIntegrationTest >> mockVersionInfo [ author: '' ancestors: #() ] - -{ #category : #tests } -EpEventIntegrationTest >> testMCVersionSaved [ - | version repository | - self skipOnPharoCITestingEnvironment. - self flag: #pharoFixMe. "Don't understand why it fails in non-interactive mode (in Jenkins)" - version := self mockVersion. - repository := MCDictionaryRepository new. - - self assert: (self countLogEventsWith: EpMonticelloVersionSave) equals: 0. - - repository storeVersion: version. - - self assert: (self countLogEventsWith: EpMonticelloVersionSave) equals: 1 -] diff --git a/src/Epicea/EpMonitor.class.st b/src/Epicea/EpMonitor.class.st index d936fbd92b4..f47c834318f 100644 --- a/src/Epicea/EpMonitor.class.st +++ b/src/Epicea/EpMonitor.class.st @@ -502,16 +502,6 @@ EpMonitor >> methodRemoved: aMethodRemovedAnnouncement [ yourself))] ] -{ #category : #'announcement handling' } -EpMonitor >> monticelloVersionSaved: aMCVersionSaved [ - - self handleAnyErrorDuring: [ - aMCVersionSaved repository description = 'cache' ifFalse: [ - self addEvent: aMCVersionSaved asEpiceaEvent ]. - "Note: Tried to encapsulate this check in the hierarchy of MCRepository - but caused troubles to iceberg, since it has a repository that's not in such hierarchy." ] -] - { #category : #'announcement handling' } EpMonitor >> protocolAdded: aProtocolAdded [ @@ -595,7 +585,6 @@ EpMonitor >> subscribeToSystemAnnouncer [ ClassRenamed -> #classRenamed:. ClassCommented -> #classCommented:. MethodRecategorized -> #methodRecategorized:. - MCVersionSaved -> #monticelloVersionSaved:. SnapshotDone -> #snapshotDone:. } do: [ :pair | diff --git a/src/Epicea/MCVersionSaved.extension.st b/src/Epicea/MCVersionSaved.extension.st deleted file mode 100644 index b72b3e5f9a6..00000000000 --- a/src/Epicea/MCVersionSaved.extension.st +++ /dev/null @@ -1,7 +0,0 @@ -Extension { #name : #MCVersionSaved } - -{ #category : #'*Epicea' } -MCVersionSaved >> asEpiceaEvent [ - - ^ EpMonticelloVersionSave version: version repository: repository -]