Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Fixed temp path definition to allow rmtree empty the 'temp' folder #2

Merged
merged 2 commits into from Jan 10, 2015

Conversation

martinrevert
Copy link
Contributor

My diagnostic of the problem was correct, but the solution was not. So, I investigated a little more and found the real cause.

shutil.rmtree was a little 'picky' when the os.path was provided with only 'temp' on all my Linux and Android Kodi nodes. Adding a null string to the end of temp path bring back de zombie shutil.rmtree and all files are deleted before download new ones.

I returned the cleaning and mkdir calls to your 'download' function, because that's a more efficient way to work compared to Opensubtitles and it has nothing to do with the problem erasing temp.

Cualquier cosa, chiflame. :)

@martinrevert
Copy link
Contributor Author

New version, more pythonish and compatible with different OS. It is Kodi only thing, I made all tests over Kodi, but please test at least in one Gotham install to ensure that the new trailing path doesn't f**k good old XBMCs.

estemendoza added a commit that referenced this pull request Jan 10, 2015
- Fixed temp path definition to allow rmtree empty the 'temp' folder
@estemendoza estemendoza merged commit 190ce19 into estemendoza:master Jan 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants