Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add realJson option. Closes #304 #305

Closed
wants to merge 2 commits into from
Closed

Add realJson option. Closes #304 #305

wants to merge 2 commits into from

Conversation

a-x-
Copy link

@a-x- a-x- commented Jul 3, 2016

No description provided.

@Constellation
Copy link
Member

I think we should change the json behavior to this one, could you update the patch?
/cc @michaelficarra

@michaelficarra
Copy link
Member

Agreed.

@michaelficarra
Copy link
Member

I'm going to close this PR, as it doesn't make much progress toward solving #304.

  • We don't need a new option. The existing json option should be sufficient.
  • We can't just naïvely wrap the key in quotes. What if it contains quotes already?
  • There's no tests.

@a-x- a-x- deleted the patch-1 branch February 1, 2018 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@a-x- @Constellation @michaelficarra