Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Multi comments in object literals are lost #94

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Contributor

tivac commented Apr 23, 2013

Not sure what expected should actually be since there's a bug, but the file I checked in is my best guess.

Test output

: Expected
    var a = {
        /* comment one */
        b : 1
    };

to match
    var a = { b: 1 };
@tivac tivac Multi comments in object literals are lost
Not sure what expected should *actually* be since there's a bug, but
here's my best guess.
672ebd8
Contributor

tivac commented Apr 29, 2013

😓

Any way I could make this more enticing? I'll try to see why the error is actually happening but I'm not very familiar with escodegen.

Owner

Constellation commented Aug 15, 2013

This issue is need to discuss. Appropriate positions of comments should be defined.

getify commented Sep 22, 2013

FYI: I've submitted a PR which I think would provide a mechanism to address this issue more broadly across all places of the code where they would be valid: Constellation#133

@tivac tivac closed this Jan 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment