use yearly ECMAScript naming scheme #132

Merged
merged 5 commits into from Aug 23, 2016

Projects

None yet

5 participants

@michaelficarra
Contributor

As discussed in #131.

@michaelficarra
Contributor

By the way, I think we should similarly rename the other files to be based on the yearly naming scheme.

@mikesherov
Contributor

@michaelficarra please do.

@michaelficarra michaelficarra changed the title from Rename es8.md to es2017.md to use yearly ECMAScript naming scheme Aug 22, 2016
@michaelficarra
Contributor
@hzoo
Contributor
hzoo commented Aug 22, 2016

👍 do we want to change the ES7/ES8 reference's in the files in this too?

@michaelficarra
Contributor

@hzoo done

@mikesherov
Contributor

👍 @rreverser merge at will.

@RReverser
Member

As part of this, could we also rename spec.md to es5.md to avoid confusion? (they're all "specs" after all)

@mikesherov
Contributor

Makes sense @rreverser.

@michaelficarra
Contributor

@RReverser done

@RReverser RReverser and 1 other commented on an outdated diff Aug 23, 2016
@@ -1,6 +1,6 @@
<!-- START doctoc generated TOC please keep comment here to allow auto update -->
<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->
-This document specifies the extensions to the [core ESTree AST types](spec.md) to support the ES6 grammar.
+This document specifies the extensions to the [core ESTree AST types](spec.md) to support the ES2015 grammar.
@RReverser
RReverser Aug 23, 2016 Member

@michaelficarra I assume this link is now broken?

@michaelficarra
michaelficarra Aug 23, 2016 Contributor

That's right. A lot of external links will also now be broken. I'll fix the internal links at least.

@ariya
Contributor
ariya commented Aug 23, 2016

A stop-gap: have a small spec.md containing an info that it's now available as es5.md.

@RReverser
Member

@ariya That, or even list of all versions with links. Anyway, I don't think many external links pointed directly to spec.md but instead to the entire repo, so we should be fine.

@michaelficarra
Contributor

Okay, should I merge then?

@mikesherov
Contributor

LGTM

@michaelficarra michaelficarra merged commit f326460 into master Aug 23, 2016
@michaelficarra michaelficarra deleted the michaelficarra-patch-1 branch Aug 23, 2016
@michaelficarra
Contributor

FYI it's starting: jquery/esprima#1524

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment