Skip to content

Add support for certificate authentication #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
garrytrinder opened this issue Jan 6, 2021 · 3 comments
Closed

Add support for certificate authentication #34

garrytrinder opened this issue Jan 6, 2021 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@garrytrinder
Copy link

garrytrinder commented Jan 6, 2021

In CLI for Microsoft 356 v3.4 we have simplified the m365 login command for certificate authentication and provided options for passing --clientId and --tenant into the login command as an alternative to our environment variables approach to use your own Azure AD identity for authentication.

It would be useful if we could extend the publish command as below to incorporate certificate authentication.

doctor publish --auth certificate --certificateBase64Encoded MIII2QIBAzCCCJ8GCSqGSIb3DQEHAaCCCJAEg...eX1N5AgIIAA== --appId 31359c7f-bd7e-475c-86db-fdb8c937548c --tenant 31359c7f-bd7e-475c-86db-fdb8c937548a --url https://contoso.sharepoint.com/sites/docs

This would extend --auth with a new option called certificate and introduce the basic options, --appId, --tenant and --certificateBase64Encoded.

tenant can be omitted if using a multi-tenant app registration

@estruyf estruyf added enhancement New feature or request help wanted Extra attention is needed labels Jan 7, 2021
@estruyf
Copy link
Owner

estruyf commented Jan 7, 2021

Thanks @garrytrinder, that would be a good enhancement!

@estruyf
Copy link
Owner

estruyf commented Feb 9, 2021

This enhancement is now available in the v1.6.0 beta version. Feel free to test it out.

Documentation how to use it has been added in the readme file from the DEV branch: https://github.com/ValoIntranet/doctor/tree/dev#certificate-authentication

@estruyf estruyf added this to the 1.6.0 milestone Feb 9, 2021
@estruyf
Copy link
Owner

estruyf commented Feb 12, 2021

Version 1.6.0 is released with this issue included.

@estruyf estruyf closed this as completed Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants