Skip to content

Add support for certificate authentication #34

Closed

Description

@garrytrinder

In CLI for Microsoft 356 v3.4 we have simplified the m365 login command for certificate authentication and provided options for passing --clientId and --tenant into the login command as an alternative to our environment variables approach to use your own Azure AD identity for authentication.

It would be useful if we could extend the publish command as below to incorporate certificate authentication.

doctor publish --auth certificate --certificateBase64Encoded MIII2QIBAzCCCJ8GCSqGSIb3DQEHAaCCCJAEg...eX1N5AgIIAA== --appId 31359c7f-bd7e-475c-86db-fdb8c937548c --tenant 31359c7f-bd7e-475c-86db-fdb8c937548a --url https://contoso.sharepoint.com/sites/docs

This would extend --auth with a new option called certificate and introduce the basic options, --appId, --tenant and --certificateBase64Encoded.

tenant can be omitted if using a multi-tenant app registration

Activity

  1. estruyf commented on Jan 7, 2021

    @estruyf
    Owner

    Thanks @garrytrinder, that would be a good enhancement!

  2. estruyf commented on Feb 9, 2021

    @estruyf
    Owner

    This enhancement is now available in the v1.6.0 beta version. Feel free to test it out.

    Documentation how to use it has been added in the readme file from the DEV branch: https://github.com/ValoIntranet/doctor/tree/dev#certificate-authentication

  3. added this to the 1.6.0 milestone on Feb 9, 2021
  4. estruyf commented on Feb 12, 2021

    @estruyf
    Owner

    Version 1.6.0 is released with this issue included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requesthelp wantedExtra attention is needed

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions