Skip to content

Mask password on output #48

Description

@SebastianSchuetze

When I use doctor and I choose password authentication and the service principal has not been approved yet, then the cli returns the error:

image

The problem here is, that you mask the password when you prompt for it but the output it in clear text. That is a pretty bad idea when you want to demo something and run into the error and everybody can see your password.

Activity

  1. self-assigned this
    on Feb 11, 2021
  2. estruyf commented on Feb 11, 2021

    @estruyf
    Owner

    Great enhancement! Thanks for suggesting this.

  3. added a commit that references this issue on Feb 11, 2021
  4. added this to the 1.6.0 milestone on Feb 11, 2021
  5. estruyf commented on Feb 11, 2021

    @estruyf
    Owner

    @SebastianSchuetze seemed this was actually coming from the CLI, but the problem is fixed. The password and certificate base64 string are both masked. Thanks again for the suggestion!

    This is now available for you to test in the latest beta.

  6. estruyf commented on Feb 12, 2021

    @estruyf
    Owner

    Version 1.6.0 is released with this issue included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions