Skip to content

Empty or null tags break the Command Palette #19

Description

@montemartin

Using the Insert Tag dialog when there is an empty tag value in the YAML tag array it is replaced with null. i.e.

tag:
  -

is rewritten to:

tag:
  - null

The null value then causes an error that breaks the command palette. The command palette still opens, and I can navigate up and down, but I can't activate any options. The only way I've found to restore it is to close VSCode and reopen. ("Reload Window" also works, but I've removed the keyboard shortcut so can't activate it without command palette.)

I believe this is related to #7 because the list of tags no longer displays if I open the Insert Tag dialog. Here is the console output when the error is triggered:

ERR Cannot read property 'toString' of null: TypeError: Cannot read property 'toString' of null
at file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:558:254
at Array.map (<anonymous>)
at E.splice (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:558:207)
at file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:34:64
at Array.forEach (<anonymous>)
at t.CombinedSpliceable.splice (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:34:51)
at file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:578:688
at t.EventBufferer.bufferEvents (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:101:214)
at M.splice (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:578:655)
at I.setElements (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1193:909)
at E.update (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1211:761)
at E.set items [as items] (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1204:518)
at file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1222:517

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions