Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: Paths within frontmatter.json should be relative #264

Closed
andikrueger opened this issue Feb 23, 2022 · 3 comments
Closed

Issue: Paths within frontmatter.json should be relative #264

andikrueger opened this issue Feb 23, 2022 · 3 comments
Projects
Milestone

Comments

@andikrueger
Copy link

Describe the bug
Currently the paths in the frontmatter.json file are absolute paths. this cases issues when working in teams and sharing code by using a repository.

To Reproduce

  1. Add Folder to frontmatter
  2. Go to 'frontmatter.json'
  3. the absolute path is stored.

Expected behavior
The path should be relative to the source directory of the project.

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows 10
@estruyf
Copy link
Owner

estruyf commented Feb 23, 2022

Thanks @andikrueger this must indeed be a bug on Windows and will be taken care of. All paths should be relative, the workspace path should normally get replaced by [[workspace]] placeholder.

@estruyf
Copy link
Owner

estruyf commented Feb 24, 2022

@andikrueger there was indeed an extra parsing required for the Windows path. This just got fixed in the latest beta version and will be added to the next main release. Thanks again for opening the issue.

@estruyf estruyf added this to In progress in 6.1.0 Feb 24, 2022
@estruyf estruyf added this to the 6.1.0 milestone Feb 24, 2022
@andikrueger
Copy link
Author

Thank you so much for the quick fix. This will help a lot.

@estruyf estruyf moved this from In progress to Done in 6.1.0 Feb 24, 2022
@estruyf estruyf closed this as completed Feb 28, 2022
@estruyf estruyf mentioned this issue Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
6.1.0
  
Done
Development

No branches or pull requests

2 participants