Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: pageFolders "previewPath" setting doesn't seem to work #393

Closed
michaeltlombardi opened this issue Sep 3, 2022 · 5 comments
Closed
Labels
bug Something isn't working Project: v8.1.0

Comments

@michaeltlombardi
Copy link

Describe the bug

Despite setting the previewPath key in frontmatter.content.pageFolders, the preview for a page still opens to <frontMatter.preview.host>/<slug>.

To Reproduce

Steps to reproduce the behavior:

  1. Add Front Matter to a hugo site

  2. Define frontMatter.preview.host as http://localhost:1313

  3. Define frontmatter.content.pageFolders as:

    "frontMatter.content.pageFolders": [
       {
         "title": "Blog Posts",
         "path": "[[workspace]]/content/posts",
         "previewPath": "posts"
       }
    ]
  4. Add foo.md in the content/posts folder

  5. Open foo.md and select Open preview

  6. Get a 404 error and see the URL for the preview is http://localhost:1313/foo instead of http://localhost:1313/posts/foo.

Expected behavior

When I set the previewPath option for a page folder, the pages in that folder should have the value of previewPath appended to the preview host before the page slug when I preview that page.

Screenshots

Screenshot of the settings in frontmatter.json

Screenshot of 404 preview beside markdown file

Desktop (please complete the following information):

  • VS Code Info:
    • Version: 1.70.2 (system setup)
    • Commit: e4503b30fc78200f846c62cf8091b76ff5547662
    • Date: 2022-08-16T05:35:13.448Z
    • Electron: 18.3.5
    • Chromium: 100.0.4896.160
    • Node.js: 16.13.2
    • V8: 10.0.139.17-electron.0
    • OS: Windows_NT x64 10.0.19044
  • Front Matter: v8.0.1

Additional context

I did notice that if I set the previewPath for the Post content type in frontMatter.taxonomy.contentTypes that works - but my problem is, for the rest of my content, it lives in subfolders of a single folder (in this case, games, like games/factions, games/factions/supplements/coasts, and so on), which would require me to redefine the content type over and over.

Screenshot of settings in frontmatter.js showing the configuration for the Factions folder and a markdown page in that folder, as well as the Post content type with previewPath set

With previewPath set on the content type, it does show the correct preview page. However, the URL seems malformed, showing http://localhost:1313/posts\automated-factions instead of http://localhost:1313/posts/automated-factions - presumably because I'm on Windows?

Screenshot of a working preview page with malformed URL

I tried using the diagnostics and output terminal to see what was going on, but the output terminal only showed me an info message saying "Receiving message from webview to panel: open-preview" and the diagnostic info didn't include anything related to the content or folder specific preview settings.

I'm not clear if I've misconfigured something or misunderstood this feature. I saw #254 which implies a future feature for being able to leverage the SSG's own preview settings, which would likely resolve my entire problem, but I thought it worthwhile to file this issue as I would expect, even with that feature, that this override would function.

@michaeltlombardi michaeltlombardi added the bug Something isn't working label Sep 3, 2022
@estruyf
Copy link
Owner

estruyf commented Sep 5, 2022

Thanks @michaeltlombardi, I'll investigate what is going on here.

@michaeltlombardi
Copy link
Author

Thank you! Hugely appreciated!

estruyf added a commit that referenced this issue Sep 5, 2022
@estruyf
Copy link
Owner

estruyf commented Sep 5, 2022

@michaeltlombardi found the issue. It had indeed to do with some Windows path parsing, and it got fixed. Feel free to test it out in the latest beta version.

@michaeltlombardi
Copy link
Author

@estruyf confirmed, it's working! Thank you enormously for this fix, this is wayyyy easier to manage. 😊

Screenshot of VS Code showing the highlighted preview path setting in the frontmatter.json file, the markdown file, and the preview for that file displaying correctly.

@estruyf
Copy link
Owner

estruyf commented Sep 6, 2022

Thanks @michaeltlombardi for confirming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Project: v8.1.0
Projects
None yet
Development

No branches or pull requests

2 participants