Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: Unable to directly preview section (_index.md) pages #396

Closed
michaeltlombardi opened this issue Sep 5, 2022 · 3 comments
Closed
Labels
bug Something isn't working Project: v8.1.0

Comments

@michaeltlombardi
Copy link

Describe the bug

With a Hugo site that has section pages, which are always named _index.md and map directly to the folder they're found in, I'm unable to preview the markdown via the Open preview command in the action bar. Instead, I have to go to the site root and navigate to the page from there.

When I try to open the preview, it always appends _index to the preview path. I can set the slug value in the markdown file's metadata, but setting it to null or an empty string puts the preview path to _index and slug is also used by Hugo.

To Reproduce
Steps to reproduce the behavior:

  1. With a Hugo site and the following file: content/foo/_index.md
  2. Set the frontmatter.json to:
    {
      "frontMatter.framework.id": "hugo",
      "frontMatter.content.publicFolder": "static",
      "frontMatter.preview.host": "http://localhost:1313",
      "frontMatter.content.pageFolders": [
        {
          "title": "Posts",
          "path": "[[workspace]]/content/foo",
          "previewPath": "foo"
        }
      ]
    }
  3. Open content/foo/_index.md
  4. Start the server
  5. Select the Open preview command
  6. See that the preview URL is http://localhost:1313/foo/_index

Expected behavior

There should be a way to override the preview path on a per-file basis (without munging the metadata for the SSG itself) to work around this issue.

Screenshots

Screenshot showing the settings, a section file, and the incorrect preview URL causing a 404 error

Desktop (please complete the following information):

  • VS Code Info:
    • Version: 1.70.2 (system setup)
    • Commit: e4503b30fc78200f846c62cf8091b76ff5547662
    • Date: 2022-08-16T05:35:13.448Z
    • Electron: 18.3.5
    • Chromium: 100.0.4896.160
    • Node.js: 16.13.2
    • V8: 10.0.139.17-electron.0
    • OS: Windows_NT x64 10.0.19044
  • Front Matter: Front Matter BETA v8.0.2993426

Additional context

I filed this as a bug because I can't see a way to preview section pages at all, but I do see that I'm sorta asking for a feature request here as well - I think being able to add metadata to override the Front Matter configuration on a per-file basis is likely really helpful, especially without the sort of SSG-aware configuration behavior described in #254.

@michaeltlombardi michaeltlombardi added the bug Something isn't working label Sep 5, 2022
@estruyf
Copy link
Owner

estruyf commented Sep 6, 2022

Good catch, will change the behavior to ignore the _index and index paths to be applied to the URL.

@estruyf
Copy link
Owner

estruyf commented Sep 7, 2022

@michaeltlombardi this has been fixed and is available for testing.

@michaeltlombardi
Copy link
Author

michaeltlombardi commented Sep 7, 2022

@estruyf it works! 💜 thanks so much for yet another awesome and quick fix!

Screenshot of an _index.md section page beside the working preview for that page

@estruyf estruyf closed this as completed Sep 22, 2022
@estruyf estruyf mentioned this issue Sep 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Project: v8.1.0
Projects
None yet
Development

No branches or pull requests

2 participants