Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add Support for Taxonomy.View in View Modes #408

Closed
jordanlambrecht opened this issue Sep 11, 2022 · 4 comments
Closed

Enhancement: Add Support for Taxonomy.View in View Modes #408

jordanlambrecht opened this issue Sep 11, 2022 · 4 comments
Labels
bug Something isn't working Project: v8.1.0

Comments

@jordanlambrecht
Copy link

The following two items are not in the documentation and do not lint correctly:

 "frontMatter.global.modes": [
    {
      "id": "minimal",
      "features": [
        "dashboard.taxonomy.view",
        "dashboard.taxonomy.manage"
      ]
    }
  ],

They seem to work, though.

Documentation page: https://frontmatter.codes/docs/panel#view-modes

@jordanlambrecht jordanlambrecht added the enhancement New feature or request label Sep 11, 2022
@estruyf estruyf added bug Something isn't working and removed enhancement New feature or request labels Sep 12, 2022
@estruyf
Copy link
Owner

estruyf commented Sep 12, 2022

Good catch @jordanlambrecht. The schema and docs seem to be missing the dashboard.taxonomy.view feature flag.

dashboard.taxonomy.manage does not exist at the moment - do you see the need for this? If so, we'll track this in another issue.

estruyf added a commit that referenced this issue Sep 12, 2022
@estruyf
Copy link
Owner

estruyf commented Sep 12, 2022

Schema and docs got updated.

@jordanlambrecht
Copy link
Author

Good catch @jordanlambrecht. The schema and docs seem to be missing the dashboard.taxonomy.view feature flag.

dashboard.taxonomy.manage does not exist at the moment - do you see the need for this? If so, we'll track this in another issue.

Not necessarily, but users may be confused because the option exists for the Snippets dashboard. I would almost say it's unnecessary for the Snippets settings because why would you not want to have the ability to edit something via the dashboard?

Thanks for making such a great product =]

@estruyf
Copy link
Owner

estruyf commented Sep 19, 2022

@jordanlambrecht thanks for the feedback 💚. For feedback, it was added because in an authoring mode, it can be that you just want to use what is defined. For taxonomy, authors might want to remap. That is why the manage type is only available for snippets and not for the taxonomy view.

It can be added to disable the actions from the taxonomy view.

@estruyf estruyf closed this as completed Sep 22, 2022
@estruyf estruyf mentioned this issue Sep 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Project: v8.1.0
Projects
None yet
Development

No branches or pull requests

2 participants