Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: frontmatter.global.modes settings #455

Closed
DennisL68 opened this issue Nov 7, 2022 · 7 comments
Closed

Issue: frontmatter.global.modes settings #455

DennisL68 opened this issue Nov 7, 2022 · 7 comments
Labels
bug Something isn't working Project: v8.2.0

Comments

@DennisL68
Copy link

DennisL68 commented Nov 7, 2022

Describe the bug
When adding frontmatter settings to settings.json using

    "frontMatter.global.activeMode": "minimal",
    "frontMatter.global.modes": [
        {
            "id": "minimal",
            "features": [
            "panel.globalSettings",
            "panel.seo",
            "panel.actions",
            "panel.otherActions",
            "dashboard.data.view",
            "dashboard.snippets.view"
            ]
        }
    ]

and when viewing a file, random panes disappears.

To Reproduce
Steps to reproduce the behavior:

  1. Open settings.json
  2. Add the JSON section in the bug description above to the end of the settings file
  3. Restart VS Code
  4. Open a FM project and go to the extension
  5. View a markdown file in the FM project

Expected behavior
The panes and dashboards should be shown in accordance with the settings.json even when working with a file.

Screenshots

image

Desktop (please complete the following information):

  • OS: Windows 10 21H2, build 19044,2130
  • VS Code :
    Version: 1.73.0 (user setup)
    Commit: 8fa188b2b301d36553cbc9ce1b0a146ccb93351f
    Date: 2022-11-01T15:34:06.111Z (6 days ago)
    Electron: 19.0.17
    Chromium: 102.0.5005.167
    Node.js: 16.14.2
    V8: 10.2.154.15-electron.0
    OS: Windows_NT x64 10.0.19044
    Sandboxed: No
  • FM: v8.1.2

Edit: I was actually doing this the wrong way around. Initially I thought these settings was for disabling the view. Not building customized views.

@DennisL68 DennisL68 added the bug Something isn't working label Nov 7, 2022
@estruyf
Copy link
Owner

estruyf commented Nov 7, 2022

Depending on which file you've opened or tab, there will be sections shown or removed.

For instance, the SEO or metadata section are only available on supported file/types.

@DennisL68
Copy link
Author

This screen dump is for a markdown file.

@estruyf
Copy link
Owner

estruyf commented Nov 8, 2022

The reason why the SEO section is not shown is probably that there is no front matter data on the file (title and description).

Actions are empty, because of the following reasons:

  • You don't have a title set in the front matter
  • You are using other as a framework
  • You did not provide a frontMatter.framework.startCommand setting value (for the known frameworks, it will use the default ones)

@estruyf
Copy link
Owner

estruyf commented Nov 8, 2022

For the SEO section, would you rather like to see this?

image

@dennisl68-castra
Copy link

Yes, I am using "other" as framework.

@dennisl68-castra
Copy link

The SEO section would benefit by your suggestion.

But I think a shorter description as "Title and Description is needed" is preferred?

@DennisL68
Copy link
Author

This isn't an issue. Just a case of not reading the documentation properly :)

@DennisL68 DennisL68 changed the title Issue: frontmatter.global.modes doesn't work in file view Issue: frontmatter.global.modes settings Dec 1, 2022
@estruyf estruyf mentioned this issue Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Project: v8.2.0
Projects
None yet
Development

No branches or pull requests

3 participants