You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
All the deleted content, this being articles or images, is not added to git when syncing. Only the modified and not added files are being added to the git commit.
Steps to reproduce
To reproduce the behavior:
Create a new file
Commit it
Delete it and perform a sync with front matter
You are going to notice that the deleted file has not been committed.
Expected Behaviour
Even the deleted files should be added in the git commit since it's a clear modification of the contents of the cms.
Solution
Around these lines of GitListener.ts, in the push() method, there should be another for loop iterating through the files contained in status.deleted adding them to the git commit.
Please let me know if I'm missing on something, I'll be happy to contribute in first person to the fix for this.
The text was updated successfully, but these errors were encountered:
Thank you @albbus-stack, for opening the issue and taking a look at it. If you feel you can fix it, and want to do a PR, you are more than welcome to do so.
I've gone ahead and added the modification in the above PR, further details are explained there. I've assumed the dev branch was the correct place, if not just merge it elsewere at your liking and close this issue. Thank you and keep up the great work
All the deleted content, this being articles or images, is not added to git when syncing. Only the modified and not added files are being added to the git commit.
Steps to reproduce
To reproduce the behavior:
You are going to notice that the deleted file has not been committed.
Expected Behaviour
Even the deleted files should be added in the git commit since it's a clear modification of the contents of the cms.
Solution
Around these lines of
GitListener.ts
, in thepush()
method, there should be another for loop iterating through the files contained instatus.deleted
adding them to the git commit.Please let me know if I'm missing on something, I'll be happy to contribute in first person to the fix for this.
The text was updated successfully, but these errors were encountered: