Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: Can't preview index.md of hugo reaf bundle with "previewPath": "/{{pathToken.relPath}}" #603

Closed
n-arakawa opened this issue Jul 12, 2023 · 3 comments
Labels

Comments

@n-arakawa
Copy link

Describe the bug

Previewing of hugo bundle(index.md) fails with 404.
Generated url is wrong when setting "previewPath" to "/{{pathToken.relPath}}"

To Reproduce

frontmatter.json

  "frontMatter.content.pageFolders": [{
    "title": "content",
    "path": "[[workspace]]/content",
    "filePrefix": null,
    "previewPath": "/{{pathToken.relPath}}"
  }]

contents

$ tree content
content
└── post
    └── bundle
        └── index.md

previewing content/post/bundle/index.md leads to wrong url:
http://localhost:1313/post/bundle/bundle

Expected behavior

expected url:
http://localhost:1313/post/bundle

Desktop (please complete the following information):

  • OS: Ubuntu2204
  • vscode: 1.79.2
  • frontMatter version: v8.4.0

Additional context

The vscode-front-matter/src/commands/Preview.ts seems try to handele index as a special case,
Howevere, slug = Article.getSlug(); at line number 100 sets slag to dir name(bundle in above example)

@n-arakawa n-arakawa added the bug Something isn't working label Jul 12, 2023
@estruyf
Copy link
Owner

estruyf commented Jul 12, 2023

Thanks, @n-arakawa, for opening this issue.

The issue here was the {{pathToken.relPath}} placeholder in combination with the location of the content.

In case when you use this placeholder, an extra check is required for page bundles.

@estruyf
Copy link
Owner

estruyf commented Jul 12, 2023

Update coming up and you will be able to test it out in the new beta.

estruyf added a commit that referenced this issue Jul 12, 2023
@estruyf estruyf changed the title Issue: Can't previe index.md of hugo reaf bundle with "previewPath": "/{{pathToken.relPath}}" Issue: Can't preview index.md of hugo reaf bundle with "previewPath": "/{{pathToken.relPath}}" Jul 13, 2023
@estruyf estruyf closed this as completed Aug 21, 2023
@theinfinit
Copy link

Hi Elio,
looks like the issue is still there. I have installed latest Front Matter CMS v10.1.0.

// frontmatter.json
{
  "$schema": "https://frontmatter.codes/frontmatter.schema.json",
  "frontMatter.framework.id": "astro",
  "frontMatter.preview.host": "http://localhost:4321",
  "frontMatter.content.publicFolder": {
    "path": "src/assets",
    "relative": true
  },
  "frontMatter.content.pageFolders": [{
      "title": "Docs",
      "path": "[[workspace]]/src/content/docs/",
      "previewPath": "{{pathToken.relPath}}"
    }
  ]
}
$ tree content
src
└── content
    └── docs
        └── index.md // http://localhost:4321/docs -> expected http://localhost:4321/
        └── test.md // http://localhost:4321/test
            └── nested
                └── index.md // http://localhost:4321/nested // This works

If I can help out with some additional context, feel free to ask.
Have a nice day 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants