Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Julien/devdata #65

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Julien/devdata #65

wants to merge 17 commits into from

Conversation

JulienParis
Copy link
Contributor

@JulienParis JulienParis commented May 6, 2020 •
edited

JulienParis
JulienParis commented May 6, 2020
View reviewed changes
Copy link
Contributor Author

@JulienParis JulienParis left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big diff mainly due to a copy-paste of a lot of files from onne place to another...

@JulienParis
Copy link
Contributor Author

@geoffreyaldebert let me know what you think

@JulienParis
Copy link
Contributor Author

Numbers displayed in preview are incorrect but it's normal : data fetched in the preview is fetched from /static-data in the repo but on master branch (which is not updated as long this PR is not merged) @geoffreyaldebert

@geoffreyaldebert
Copy link
Collaborator

good pour moi on refera une PR plus tard lorsqu'on aura vérifier que tout marche depuis static-data pour remove les copies de fichiers inutiles dans frontend/static/...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@geoffreyaldebert geoffreyaldebert

@JulienParis JulienParis

Labels
backend code data front optimisation
Projects
dashboard - V.1.xx
  
Awaiting triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JulienParis @geoffreyaldebert