From 47f0d9e0326f3cc31c801a0ecf7312d1049ece3e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9ment=20P=C3=A9ron?= Date: Mon, 25 Sep 2023 03:49:24 +0200 Subject: [PATCH] cmake: fix when cross compiling (#252) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit To compile protobuf, CMake needs to use the protoc and grpc-cpp-plugin in the host architecture. Unfortunately by default the protoc and grpc-cpp-plugin are the one for the Target. And since gRPC 1.52 they are explictly not exported when Cross Compiling to avoid architecture mismatch. See: https://github.com/grpc/grpc/commit/831d2a6855da36998e24f46e6b2a5b6f6042ad1a Fix this by looking at the correct program See example. https://github.com/grpc/grpc/blob/master/examples/cpp/cmake/common.cmake#L54-L62 Signed-off-by: Clément Péron --- CMakeLists.txt | 28 ++++++++++++++++++++++++++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 5aa1310..80ebad2 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -120,10 +120,34 @@ if(Protobuf_PROTOC_EXECUTABLE) endif() endif() +# When cross compiling we look for the native protoc compiler +# overwrite protobuf::protoc with the proper protoc +if(CMAKE_CROSSCOMPILING) + find_program(Protobuf_PROTOC_EXECUTABLE REQUIRED NAMES protoc) + if(NOT TARGET protobuf::protoc) + add_executable(protobuf::protoc IMPORTED) + endif() + set_target_properties(protobuf::protoc PROPERTIES + IMPORTED_LOCATION "${Protobuf_PROTOC_EXECUTABLE}") +endif() + find_package(gRPC QUIET) -if(gRPC_FOUND AND TARGET gRPC::grpc AND TARGET gRPC::grpc_cpp_plugin) +if(gRPC_FOUND AND TARGET gRPC::grpc) + # When cross compiling we look for the native grpc_cpp_plugin + if(CMAKE_CROSSCOMPILING) + find_program(GRPC_CPP_PLUGIN REQUIRED NAMES grpc_cpp_plugin) + if(NOT TARGET gRPC::grpc_cpp_plugin) + add_executable(gRPC::grpc_cpp_plugin IMPORTED) + endif() + set_target_properties(gRPC::grpc_cpp_plugin PROPERTIES + IMPORTED_LOCATION "${GRPC_CPP_PLUGIN}") + elseif(TARGET gRPC::grpc_cpp_plugin) + get_target_property(GRPC_CPP_PLUGIN gRPC::grpc_cpp_plugin LOCATION) + else() + message(FATAL_ERROR "Found gRPC but no gRPC CPP plugin defined") + endif() + set(GRPC_LIBRARIES gRPC::gpr gRPC::grpc gRPC::grpc++) - get_target_property(GRPC_CPP_PLUGIN gRPC::grpc_cpp_plugin LOCATION) get_target_property(GRPC_INCLUDE_DIR gRPC::grpc INTERFACE_INCLUDE_DIRECTORIES) else() include(${CMAKE_CURRENT_SOURCE_DIR}/cmake/FindGRPC.cmake)