[codereview]:saveCrc(prevCrc uint32) parameter make no sense

[woodliu]

etcd/server/storage/wal/wal.go

Line 968 in ea24fb8

func (w *WAL) saveCrc(prevCrc uint32) error {

saveCrc use prevCrc as it's only parameter, then pass it to w.encoder.encode(&walpb.Record{Type: crcType, Crc: prevCrc}).
But in function encode, it just override the input rec.Crc like below, so i think the parameter for saveCrc is useless

func (e *encoder) encode(rec *walpb.Record) error {
	e.mu.Lock()
	defer e.mu.Unlock()

	e.crc.Write(rec.Data)
	rec.Crc = e.crc.Sum32()
        ......
}

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.