Jump to conversation
Unresolved conversations (13)
@xiang90 xiang90 Jul 26, 2019
anyway we can make this more deterministic? we should avoid random wait.
clientv3/integration/black_hole_test.go
spzala gyuho
@spzala spzala Jul 26, 2019
Changelog needs to be updated for all these changes here - we can do it in a separate PR but mentioning here for reference.
go.mod
@spzala spzala Jul 26, 2019
nit, `custom` instead of customer
Outdated
clientv3/config.go
@jpbetz jpbetz Jul 26, 2019
This looks right to me. @wenjiaswe Would you double check this function as well? Docs for ClientHandshake here: https://godoc.org/google.golang.org/grpc/credentials#TransportCredentials
clientv3/credentials/credentials.go
wenjiaswe
@jpbetz jpbetz Jul 26, 2019
pointer needed? just do `authTokenMu sync.RWMutex` to eliminate `authTokenMu: new(sync.RWMutex)` below?
Outdated
clientv3/credentials/credentials.go
@jpbetz jpbetz Jul 26, 2019
``` return &transportCredential{ gtc: tc.gtc.Clone() } ``` ? (I realize we're not using it for anything, but just to future proof..)
Outdated
clientv3/credentials/credentials.go
@jpbetz jpbetz Jul 25, 2019
Remove comments about picker configuration and `Custom` picker enum in this PR and instead open an issue about it? It's a adds quite a bit of noise in this PR, might be better to just leave it out of the code until we decide to implement something. Same for custom balancers.
clientv3/balancer/balancer.go
@jpbetz jpbetz Jul 25, 2019
balances
Outdated
clientv3/balancer/picker/picker.go
@jpbetz jpbetz Jul 25, 2019
nit: Log a warn or something if none of the cases match?
...tv3/balancer/connectivity/connectivity.go
@jpbetz jpbetz Jul 25, 2019
nit: Can we just do: ```go rc.mu.RLock() defer rc.mu.RUnlock() return rc.cur ``` ?
Outdated
...tv3/balancer/connectivity/connectivity.go
@jpbetz jpbetz Jul 25, 2019
Update comment to reflect that we're calling `updatedPicker` now instead `regeneratePicker`?
Outdated
clientv3/balancer/balancer.go
@xiang90 xiang90 Jul 25, 2019
do we need to check authority is an IP address rather than a DNS name?
Outdated
clientv3/credentials/credentials.go
@jingyih jingyih Jul 23, 2019
nit: "grpccredentials.TransportCredentials"
Outdated
clientv3/credentials/credentials.go
Resolved conversations (0)