Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: log server-side /health checks #11704

Merged
merged 1 commit into from Mar 18, 2020
Merged

*: log server-side /health checks #11704

merged 1 commit into from Mar 18, 2020

Conversation

@gyuho
Copy link
Member

gyuho commented Mar 18, 2020

To make it easier to root-cause when /health check fails.
For example, we are using load balancer to health check
each etcd instance, and when one etcd node gets terminated,
it's hard to tell whether etcd "server" was really failing
or client (or load balancer") failed to reach the etcd cluster
which is also failure in load balancer health check.

{"level":"info","ts":"2020-03-18T10:56:05.206-0700","caller":"etcdhttp/metrics.go:65","msg":"/health OK","http-error-code":200}

@gyuho

This comment has been minimized.

Copy link
Member Author

gyuho commented Mar 18, 2020

To make it easier to root-cause when /health check fails.
For example, we are using load balancer to health check
each etcd instance, and when one etcd node gets terminated,
it's hard to tell whether etcd "server" was really failing
or client (or load balancer") failed to reach the etcd cluster
which is also failure in load balancer health check.

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@gyuho gyuho force-pushed the gyuho:log-health branch from f45f0e5 to 92f180c Mar 18, 2020
@wenjiaswe

This comment has been minimized.

Copy link
Contributor

wenjiaswe commented Mar 18, 2020

/lgtm thanks!

@gyuho gyuho merged commit b50c92c into etcd-io:master Mar 18, 2020
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
semaphoreci The build passed on Semaphore.
Details
@gyuho gyuho deleted the gyuho:log-health branch Mar 18, 2020
gyuho added a commit that referenced this pull request Mar 18, 2020
ref.
#11704

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
gyuho added a commit that referenced this pull request Mar 18, 2020
ref.
#11704

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
gyuho added a commit that referenced this pull request Mar 18, 2020
ref.
#11704

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
gyuho added a commit that referenced this pull request Mar 18, 2020
ref.
#11704

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
gyuho added a commit that referenced this pull request Mar 18, 2020
ref.
#11704

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
gyuho added a commit that referenced this pull request Mar 19, 2020
ref.
#11704

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.