Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mvcc: add a fast return at put method #13601

Merged
merged 3 commits into from
Jan 19, 2022
Merged

mvcc: add a fast return at put method #13601

merged 3 commits into from
Jan 19, 2022

Conversation

lixd
Copy link
Contributor

@lixd lixd commented Jan 15, 2022

return when two leaseID is equal, avoid invalid operations.

Fixes #13600

@lixd
mvcc: add a fast return at put method
401cc1a 
return when two leaseID is equal, avoid invalid operations.

Fixes #13600
ptabor
ptabor approved these changes Jan 15, 2022
View reviewed changes
Copy link
Contributor

@ptabor ptabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM. Thank you.
Please add a test-case for the new code-path.

@lixd
mvcc: add test-case
1d70617 
a test-case for new code-path.
ptabor
ptabor approved these changes Jan 16, 2022
View reviewed changes
Copy link
Contributor

@ptabor ptabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the change and test.

@ptabor ptabor self-assigned this Jan 16, 2022
@lixd
Copy link
Contributor Author

lixd commented Jan 17, 2022 •
edited
Loading

hi, what's wrong with checks, need to change anything？ @ptabor

@serathius
Copy link
Member

@lixd CodeQL Checks are broken, please ignore them. Tracking issue #13588

@lixd
Copy link
Contributor Author

lixd commented Jan 17, 2022 •
edited
Loading

@lixd CodeQL Checks are broken, please ignore them. Tracking issue #13588

@serathius thanks, but there is a test (linux-amd64-integration-2-cpu) check fail, in fact, I don know how to fix it.
i see others test like (linux-amd64-integration-1-cpu) and test (linux-amd64-integration-4-cpu) are passed.

@serathius
Copy link
Member

linux-amd64-integration-2-cpu fail is a flake, please do an empty commit append and force-push the change again to retrigger the CI.

@lixd
Copy link
Contributor Author

lixd commented Jan 17, 2022

@serathius needs an approval thanks.

@lixd
Copy link
Contributor Author

lixd commented Jan 18, 2022

@serathius it passed this time, maybe there is some problem whit CI.
and can this pr be merged? @ptabor

@ptabor ptabor merged commit 14a661e into etcd-io:main Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serathius serathius serathius approved these changes

@ptabor ptabor ptabor approved these changes

Assignees

@ptabor ptabor

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

maybe there is an invalid operation at the put method
3 participants
@lixd @serathius @ptabor