From 4c013c91e90a5f2f8b226ba81476707c47c42f5d Mon Sep 17 00:00:00 2001 From: Mike Dame Date: Fri, 5 Aug 2022 14:56:35 +0000 Subject: [PATCH] Change default sampling rate from 100% to 0% This changes the default parent-based trace sampling rate from 100% to 0%. Due to the high QPS etcd can handle, having 100% trace sampling leads to very high resource usage. Defaulting to 0% means that only already-sampled traces will be sampled in etcd. Fixes #14310 Signed-off-by: Mike Dame --- server/embed/etcd.go | 1 + 1 file changed, 1 insertion(+) diff --git a/server/embed/etcd.go b/server/embed/etcd.go index 5d7713edf08..5a1a653136d 100644 --- a/server/embed/etcd.go +++ b/server/embed/etcd.go @@ -849,6 +849,7 @@ func (e *Etcd) setupTracing(ctx context.Context) (exporter tracesdk.SpanExporter tracesdk.NewTracerProvider( tracesdk.WithBatcher(exporter), tracesdk.WithResource(res), + tracesdk.WithSampler(tracesdk.ParentBased(tracesdk.NeverSample())), ), ), )