Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] clientv3: do not refresh token when users use CommonName based authentication #14790

merged 3 commits into from Nov 17, 2022


Copy link

@ahrtr ahrtr commented Nov 16, 2022

Backport #14770 to 3.5.

Issue: #14764


When users use the TLS CommonName based authentication, the
authTokenBundle is always nil. But it's possible for the clients
to get `rpctypes.ErrAuthOldRevision` response when the clients
concurrently modify auth data (e.g, addUser, deleteUser etc.).
In this case, there is no need to refresh the token; instead the
clients just need to retry the operations (e.g. Put, Delete etc).

Signed-off-by: Benjamin Wang <>
Signed-off-by: Benjamin Wang <>
Refer to etcd-io#14764

Signed-off-by: Benjamin Wang <>
Copy link
Member Author

ahrtr commented Nov 17, 2022

cc @mitake @ptabor @serathius @spzala

@serathius serathius merged commit b282163 into etcd-io:release-3.5 Nov 17, 2022
13 checks passed
@serathius serathius mentioned this pull request Nov 17, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants