Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix trivial issues as I see them #604

Merged
merged 1 commit into from
Mar 4, 2014
Merged

fix trivial issues as I see them #604

merged 1 commit into from
Mar 4, 2014

Conversation

ccding
Copy link
Contributor

@ccding ccding commented Feb 27, 2014

No description provided.

@philips
Copy link
Contributor

philips commented Mar 3, 2014

@ccding Thanks for the patches. The gofmt patch will be hard to land because of changes in master between PRs. But, I would love to take the typo fixes. Can you remove the gofmt and just do the typo fixes? Also, if you can follow the guidelines of the commit messages in CONTRIBUTING.md that would be great.

In this case it would be:

"fix(Documentation/*): fix various typos"

@ccding
Copy link
Contributor Author

ccding commented Mar 4, 2014

thanks for the comments. updated already

@philips
Copy link
Contributor

philips commented Mar 4, 2014

perfect, lgtm. merging.

philips added a commit that referenced this pull request Mar 4, 2014
fix trivial issues as I see them
@philips philips merged commit 49253d8 into etcd-io:master Mar 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants