Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lease: LeaseTimeToLive returns TTL=-1 resp on lease not found #7305

Merged
merged 3 commits into from Feb 13, 2017

Conversation

4 participants
@fanminshi
Copy link
Member

commented Feb 10, 2017

No description provided.

@fanminshi fanminshi force-pushed the fanminshi:return_header_for_timetolive branch from db118ff to bead6bd Feb 11, 2017

@fanminshi

This comment has been minimized.

Copy link
Member Author

commented Feb 11, 2017

ALL fixed PTAL /c @heyitsanthony

@fanminshi fanminshi force-pushed the fanminshi:return_header_for_timetolive branch from bead6bd to c32e491 Feb 11, 2017

@fanminshi fanminshi changed the title lease: always return header for timetolive lease: LeaseTimeToLive returns TTL=-1 resp on lease not found Feb 11, 2017

@fanminshi fanminshi force-pushed the fanminshi:return_header_for_timetolive branch from c32e491 to bcfbb09 Feb 11, 2017

@fanminshi

This comment has been minimized.

Copy link
Member Author

commented Feb 11, 2017

ALL fixed. PTAL

@heyitsanthony

This comment has been minimized.

Copy link
Contributor

commented Feb 11, 2017

lgtm

@codecov-io

This comment has been minimized.

Copy link

commented Feb 11, 2017

Codecov Report

❗️ No coverage uploaded for pull request base (master@9f8e82e). Click here to learn what that means.

@@            Coverage Diff            @@
##             master    #7305   +/-   ##
=========================================
  Coverage          ?   65.03%           
=========================================
  Files             ?      230           
  Lines             ?    20728           
  Branches          ?        0           
=========================================
  Hits              ?    13480           
  Misses            ?     6259           
  Partials          ?      989

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f8e82e...0d08ffa. Read the comment docs.

@fanminshi fanminshi merged commit 2925f02 into etcd-io:master Feb 13, 2017

3 of 5 checks passed

jenkins-ppc64le Build finished.
Details
jenkins-proxy-ci Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-cov Build finished.
Details
semaphoreci The build passed on Semaphore.
Details

@mwf mwf referenced this pull request May 2, 2017

Closed

v3.2.0-rc.0 compatability #7851

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.