Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdserver/api/v2discovery: simplify !(x == y) to x != y #9969

Merged
merged 1 commit into from
Jul 28, 2018
Merged

etcdserver/api/v2discovery: simplify !(x == y) to x != y #9969

merged 1 commit into from
Jul 28, 2018

Conversation

quasilyte
Copy link
Contributor

@quasilyte
Copy link
Contributor Author

This is for readability, not for performance reasons. :)
Fewer "mind clocks".

@xiang90
Copy link
Contributor

xiang90 commented Jul 28, 2018

lgtm

@codecov-io
Copy link

Codecov Report

Merging #9969 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9969      +/-   ##
==========================================
+ Coverage   69.17%   69.21%   +0.03%     
==========================================
  Files         386      386              
  Lines       35914    35914              
==========================================
+ Hits        24844    24858      +14     
+ Misses       9264     9259       -5     
+ Partials     1806     1797       -9
Impacted Files Coverage Δ
etcdserver/api/v2discovery/discovery.go 68.82% <100%> (ø) ⬆️
pkg/adt/interval_tree.go 79.87% <0%> (-11.12%) ⬇️
etcdserver/api/v3rpc/lease.go 65.9% <0%> (-7.96%) ⬇️
etcdctl/ctlv3/command/lease_command.go 65.34% <0%> (-5.95%) ⬇️
pkg/logutil/zap_grpc.go 47.61% <0%> (-4.77%) ⬇️
lease/leasehttp/http.go 58.08% <0%> (-1.48%) ⬇️
etcdctl/ctlv3/command/printer_simple.go 72.48% <0%> (-1.35%) ⬇️
etcdserver/api/v2http/client.go 85.51% <0%> (-1.21%) ⬇️
etcdserver/v3_server.go 73.42% <0%> (-1.17%) ⬇️
etcdserver/raft.go 80.09% <0%> (-0.72%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90a2fbe...d0f800c. Read the comment docs.

@xiang90 xiang90 merged commit d1f49d4 into etcd-io:master Jul 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants