Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment Count Fallback #125

Merged
merged 1 commit into from Aug 15, 2016
Merged

Comment Count Fallback #125

merged 1 commit into from Aug 15, 2016

Conversation

jswrenn
Copy link
Contributor

@jswrenn jswrenn commented Aug 14, 2016

Fallback for problem described in #123. Empty comment anchor tags are displayed with the content '馃挰', which gives a visual indication of where to click to view comments, even if parsing the comment count fails.

Before:
Without Patch
After:
With Patch

This patch strictly addresses the poor behavior in the event of a failure, not the underlying cause of the failure. Patch #124 fixes the underlying cause of failure, but this patch provides a dash of future proofing.

Fallback for problem described in etcet#123. Empty comment anchor tags are displayed with the content '馃挰', which gives a visual indication of where to click to view comments, even if parsing the comment count fails.
@etcet etcet merged commit 080f560 into etcet:master Aug 15, 2016
@etcet
Copy link
Owner

@etcet etcet commented Aug 15, 2016

I don't have this character on my laptop but it's better than nothing, thanks!

@jswrenn jswrenn deleted the patch-1 branch Aug 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants