Comment Count Fallback #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fallback for problem described in etcet#123. Empty comment anchor tags are displayed with the content '💬', which gives a visual indication of where to click to view comments, even if parsing the comment count fails.
Owner
|
I don't have this character on my laptop but it's better than nothing, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fallback for problem described in #123. Empty comment anchor tags are displayed with the content '💬', which gives a visual indication of where to click to view comments, even if parsing the comment count fails.
Before:
After:
This patch strictly addresses the poor behavior in the event of a failure, not the underlying cause of the failure. Patch #124 fixes the underlying cause of failure, but this patch provides a dash of future proofing.