Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

Remove libiconv duplicate

Commit ee2c3ab ("Remove spurious libiconv dependencies") pruned all
existing "depends_on 'libiconv'" usages from Homebrew in preparation for
removing the libiconv dupe itself.

Now that is done, and we can remove and blacklist it. It can be obtained
from Homebrew-alt.

Closes #10464.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>

Conflicts:

	Library/Homebrew/cmd/doctor.rb
  • Loading branch information...
commit 025eecd37e6b2923f977c984e1e2c371629b7f1b 1 parent e797919
camillol authored February 25, 2012 etehtsea committed March 17, 2012
5  Library/Homebrew/blacklist.rb
@@ -6,6 +6,11 @@ def blacklisted? name
6 6
   when 'libarchive', 'libpcap' then <<-EOS.undent
7 7
     Apple distributes #{name} with OS X, you can find it in /usr/lib.
8 8
     EOS
  9
+  when 'libiconv' then <<-EOS.undent
  10
+    Apple distributes #{name} with OS X, you can find it in /usr/lib.
  11
+    Some build scripts fail to detect it correctly, please check existing
  12
+    formulae for solutions.
  13
+    EOS
9 14
   when 'libxml', 'libxlst' then <<-EOS.undent
10 15
     Apple distributes #{name} with OS X, you can find it in /usr/lib.
11 16
     However not all build scripts look for these hard enough, so you may need
2  Library/Homebrew/doctor.rb
@@ -311,7 +311,7 @@ def xcode_prefix
311 311
         if prefix.to_s.match(' ')
312 312
           <<-EOS.undent
313 313
             Xcode is installed to a directory with a space in the name.
314  
-            This will cause some formulae, such as libiconv, to fail to build.
  314
+            This will cause some formulae to fail to build.
315 315
           EOS
316 316
         end
317 317
       end

0 notes on commit 025eecd

Please sign in to comment.
Something went wrong with that request. Please try again.