Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can only set cookies to cookies_max_age #33

Closed
lewilewilewi opened this issue Jun 16, 2015 · 5 comments
Closed

Can only set cookies to cookies_max_age #33

lewilewilewi opened this issue Jun 16, 2015 · 5 comments
Assignees
@Etenil
Labels
question

Comments

@lewilewilewi
Copy link

You ought to be able to pass an expiry into setCookie - currently you can only set cookies for $cookies_max_age
@Etenil Etenil self-assigned this Jul 11, 2015
@Etenil
Copy link
Owner

Etenil commented Jul 11, 2015

I've committed a fix in branch fix-33-cookies-maxage. Please test if satisfactory.

@Etenil
Copy link
Owner

Etenil commented Dec 6, 2015

@lewilewilewi is the fix working?

@lewilewilewi
Copy link
Author

Sorry, I forgot to come back to this!
There's an issue with getAllCookies where there are two return statements, the new code won't run ever.

@Etenil Etenil closed this as completed in b5e5435 Jan 17, 2016
@Etenil
Copy link
Owner

Etenil commented Jan 17, 2016

@lewilewilewi Sorry about that, I've updated the branch to remove the error, added unit tests to cover it and merged into master.

@lewilewilewi
Copy link
Author

Forgot to let you know that this is looking good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Etenil Etenil

Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Etenil @lewilewilewi