New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ollydbg style Register view fonts don't update immediately #456

Open
eteran opened this Issue Oct 6, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@eteran
Owner

eteran commented Oct 6, 2016

When updating the fonts in the appearance settings, all of the widgets update immediately to the new font settings. However, the new Register view does not yet.

@eteran

This comment has been minimized.

Show comment
Hide comment
@eteran

eteran Oct 6, 2016

Owner

I think we will need to make a "configuration changed" signal that things can register for. I'll start with that :-)

Owner

eteran commented Oct 6, 2016

I think we will need to make a "configuration changed" signal that things can register for. I'll start with that :-)

@eteran

This comment has been minimized.

Show comment
Hide comment
@eteran

eteran Oct 6, 2016

Owner

@10110111 I've stubbed out the code for this.

I've added a signal to Configuration which the OdbgRegisterView now connects to its settingsUpdated function. And it already has some code to update the font. However, I'm not familiar enough with this code to know how to update the spacing between items in the view.

Owner

eteran commented Oct 6, 2016

@10110111 I've stubbed out the code for this.

I've added a signal to Configuration which the OdbgRegisterView now connects to its settingsUpdated function. And it already has some code to update the font. However, I'm not familiar enough with this code to know how to update the spacing between items in the view.

@10110111

This comment has been minimized.

Show comment
Hide comment
@10110111

10110111 Oct 6, 2016

Contributor

It may actually be easier to recreate the widget. I don't remember whether I have put any effort at making it resizable on the fly.

In fact, maybe not recreate the widget itself, just move filling of canvas from ODBRegView::ODBRegView() to a separate function, and on signal just clear the canvas and call this function. I'm not sure whether I'll be able to do it myself soon enough.

Contributor

10110111 commented Oct 6, 2016

It may actually be easier to recreate the widget. I don't remember whether I have put any effort at making it resizable on the fly.

In fact, maybe not recreate the widget itself, just move filling of canvas from ODBRegView::ODBRegView() to a separate function, and on signal just clear the canvas and call this function. I'm not sure whether I'll be able to do it myself soon enough.

@eteran

This comment has been minimized.

Show comment
Hide comment
@eteran

eteran Oct 6, 2016

Owner

OK, i'll take a look at the code at some point to see what the simplest approach will be.

Owner

eteran commented Oct 6, 2016

OK, i'll take a look at the code at some point to see what the simplest approach will be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment