New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary String search has unecessary "keep size" button #574

Closed
eteran opened this Issue Jul 23, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@eteran
Owner

eteran commented Jul 23, 2017

The widget for users manipulating binary data has a "keep size" check box that makes a lot of sense for the case of editing existing binary data. However, since we reuse that widget for the Binary string search plugin, that dialog also has it... which makes no sense.

So we need to make the "keep" check box an optional component.

eteran added a commit that referenced this issue May 14, 2018

@eteran eteran closed this May 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment