Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Consider embedding libraries in source tree #735
I was thinking, we basically have 3 uncommon dependencies.
These are all relatively speaking, small. It may be reasonable to have a
This lets us have a simpler dependency process, potentially lock in versions we are sensitive to, and make these dependencies unconditional, which is just simpler.
I wouldn't say
So in summary, I don't think it's useful to bundle these libraries with EDB source, at least not all of them.
Fair enough points. I agree about
Regarding Capstone, I'm kinda in the middle on it. Not because it isn't routinely packaged, but the version of it available from repos is a bit unreliable.
For example, I ran into errors doing the ARM32 build testing because one system had capstone 4 and another had capstone 3. If we had it baked in, we could just say "we use capstone 4 always".
But if I'm being honest,
So yea, I agree with your "not all of them" assessment.