Please sign in to comment.
Syncmanager: fix an issue causing local cache corruption when failing…
… to push. Due to a logical issue in the code, new journal entries were added to the local cache after they've been created locally, and not after they've been added to the server. Under normal circumstances this doesn't pose a problem, however when pushing to the server fails, the local cache would have the new entries as if they were saved on the server, causing the app to think there has been a corruption on the server (as entries should never be removed from the server) and halt the sync. This change makes it so the entries are saved to the local cache only after they've been saved on the server. Note: this was not spotted until now because it relies on an unfortunate specific sequence of events. It only happens when creating journal entries, and when trying to sync them successfully connecting to the server to fetch the journal list and the content of the journal itself, and only failing when coming to push the journals. Many thanks to "359" (this user's preferred alias) for reporting the issue that resulted in this fix.
- Loading branch information...
Showing with 5 additions and 1 deletion.